Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker: Prepare day buttons for 40px default size #68156

Merged
merged 2 commits into from
Dec 20, 2024
Merged

DatePicker: Prepare day buttons for 40px default size #68156

merged 2 commits into from
Dec 20, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Dec 19, 2024 •
edited
Loading

In preparation for #65751

What?

Opts in the day buttons in DatePicker to the new default size, ensuring that they won't break.

Testing Instructions

See Storybook for DatePicker. There should be no visual changes.

@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Dec 19, 2024
@mirka mirka self-assigned this Dec 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

Flaky tests detected in 70ec7dc.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12423247160
📝 Reported issues:

@mirka mirka marked this pull request as ready for review December 20, 2024 00:37
@mirka mirka requested a review from ajitbohra as a code owner December 20, 2024 00:37
@mirka mirka requested a review from a team December 20, 2024 00:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <[email protected]>
Co-authored-by: ciampo <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

ciampo
ciampo approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

The style overrides on those buttons make it so that there isn't any visual difference even after applying the new 40px size

tyxla
tyxla approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, thank you 🚀

@mirka mirka merged commit 0adbeba into trunk Dec 20, 2024
69 checks passed
@mirka mirka deleted the date-picker-button branch December 20, 2024 14:24
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

@ciampo ciampo ciampo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@mirka mirka

Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mirka @ciampo @tyxla